svenvh added a comment. It would be good if you could provide some motivation for this change in the description of this review.
================ Comment at: include/clang/Basic/DiagnosticParseKinds.td:1157 -// OpenCL C++. +// C++ for OpenCL. def err_openclcxx_virtual_function : Error< ---------------- Please align on either "C++ for OpenCL" or "C++ for OpenCL mode" (in DiagnosticCommonKinds.td). ================ Comment at: lib/Sema/SemaDecl.cpp:6429 - // OpenCL C++ 1.0 s2.9: the thread_local storage qualifier is not - // supported. OpenCL C does not support thread_local either, and + // C++ for OpenCL does not allow thread_local storage qualifier. + // OpenCL C does not support thread_local either, and ---------------- *the* thread_local storage qualifier. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64867/new/ https://reviews.llvm.org/D64867 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
