plotfi marked 2 inline comments as done. plotfi added inline comments.
================ Comment at: clang/lib/Driver/Types.cpp:305 + P.clear(); + for (auto Phase : getInfo(Id).Phases) + P.push_back(Phase); ---------------- aaron.ballman wrote: > plotfi wrote: > > aaron.ballman wrote: > > > Can't you use the local `Phases` object instead of calling `getInfo()` > > > again? This seems like it wants to be `P = Phases;` > > Oh yeah sure. I can change that. Anything else pop out at you? > You can drop the `P.clear()` as part of that assignment, but otherwise, no. Ahh. I understand what you mean now. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
