SureYeaah added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:427
R"cpp(void f(int a) {
auto dummy = 1; label: [ [gsl::suppress("type")] ] for
(;;) a = dummy;
})cpp"},
----------------
kadircet wrote:
> I think `auto dummy = 1;` should be within the label. otherwise we might
> break codes like(which is basically anything with labels):
> ```
> void foo() {
> goto label;
> label:
> a = 1;
> }
> ```
>
> I don't think it is that important though, and have no idea about the effort
> necessary feel free to just add a FIXME if it turns out hard.
I've disabled extraction from label statements and added a fixme because the
fix for all kinds of loops as well as if statement needs another patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64717/new/
https://reviews.llvm.org/D64717
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
