juliehockett added a comment.
Looks mostly good to me, with a small formatting thing
================
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:490
Out.emplace_back(llvm::make_unique<TagNode>(HTMLTag::TAG_H3, I.Name));
+ Out.back()->Attributes.try_emplace("id",
+ llvm::toHex(llvm::toStringRef(I.USR)));
----------------
Comment here that you're using USR instead of name to disambiguate function
overloads (mostly because I asked the question and had to think about why for a
second, so might as well document it)
================
Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52
+<ul>
+ <li><span><a href="#Namespaces">Namespaces</a></span></li>
+ <li><span><a href="#Records">Records</a></span></li>
+ <li><span><a href="#Functions">Functions</a></span><ul>
+ <li><span><a
href="#0000000000000000000000000000000000000000">OneFunction</a></span></li>
+</ul></li>
----------------
Formatting is a bit weird for sublists
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65030/new/
https://reviews.llvm.org/D65030
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
