NoQ updated this revision to Diff 212257. NoQ added a comment. Hmm, on second thought... Make the pointers a bit darker in dark mode.
F9692102: Screen Shot 2019-07-29 at 5.31.14 PM.png <https://reviews.llvm.org/F9692102> CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65427/new/ https://reviews.llvm.org/D65427 Files: clang/test/Analysis/exploded-graph-rewriter/escapes.c clang/test/Analysis/exploded-graph-rewriter/store.dot clang/utils/analyzer/exploded-graph-rewriter.py Index: clang/utils/analyzer/exploded-graph-rewriter.py =================================================================== --- clang/utils/analyzer/exploded-graph-rewriter.py +++ clang/utils/analyzer/exploded-graph-rewriter.py @@ -644,6 +644,10 @@ if st is None: self._dump('<i> Nothing!</i>') else: + if self._dark_mode: + self._dump(' <font color="gray30">(%s)</font>' % st.ptr) + else: + self._dump(' <font color="gray">(%s)</font>' % st.ptr) if prev_st is not None: if s.store.is_different(prev_st): self._dump('</td></tr><tr><td align="left">') Index: clang/test/Analysis/exploded-graph-rewriter/store.dot =================================================================== --- clang/test/Analysis/exploded-graph-rewriter/store.dot +++ clang/test/Analysis/exploded-graph-rewriter/store.dot @@ -4,6 +4,7 @@ // UNSUPPORTED: system-windows // CHECK: <b>Store: </b> +// CHECK-SAME: <font color="gray">(0x2)</font> // CHECK-SAME: <table border="0"> // CHECK-SAME: <tr> // CHECK-SAME: <td align="left"> Index: clang/test/Analysis/exploded-graph-rewriter/escapes.c =================================================================== --- clang/test/Analysis/exploded-graph-rewriter/escapes.c +++ clang/test/Analysis/exploded-graph-rewriter/escapes.c @@ -9,7 +9,7 @@ // UNSUPPORTED: system-windows void escapes() { - // CHECK: <td align="left"><b>Store: </b></td> + // CHECK: <td align="left"><b>Store: </b> <font color="gray">(0x{{[0-9a-f]*}})</font></td> // CHECK-SAME: <td align="left">foo</td><td align="left">0</td> // CHECK-SAME: <td align="left">&Element\{"foo",0 S64b,char\}</td> // CHECK: <td align="left"><b>Environment: </b></td>
Index: clang/utils/analyzer/exploded-graph-rewriter.py =================================================================== --- clang/utils/analyzer/exploded-graph-rewriter.py +++ clang/utils/analyzer/exploded-graph-rewriter.py @@ -644,6 +644,10 @@ if st is None: self._dump('<i> Nothing!</i>') else: + if self._dark_mode: + self._dump(' <font color="gray30">(%s)</font>' % st.ptr) + else: + self._dump(' <font color="gray">(%s)</font>' % st.ptr) if prev_st is not None: if s.store.is_different(prev_st): self._dump('</td></tr><tr><td align="left">') Index: clang/test/Analysis/exploded-graph-rewriter/store.dot =================================================================== --- clang/test/Analysis/exploded-graph-rewriter/store.dot +++ clang/test/Analysis/exploded-graph-rewriter/store.dot @@ -4,6 +4,7 @@ // UNSUPPORTED: system-windows // CHECK: <b>Store: </b> +// CHECK-SAME: <font color="gray">(0x2)</font> // CHECK-SAME: <table border="0"> // CHECK-SAME: <tr> // CHECK-SAME: <td align="left"> Index: clang/test/Analysis/exploded-graph-rewriter/escapes.c =================================================================== --- clang/test/Analysis/exploded-graph-rewriter/escapes.c +++ clang/test/Analysis/exploded-graph-rewriter/escapes.c @@ -9,7 +9,7 @@ // UNSUPPORTED: system-windows void escapes() { - // CHECK: <td align="left"><b>Store: </b></td> + // CHECK: <td align="left"><b>Store: </b> <font color="gray">(0x{{[0-9a-f]*}})</font></td> // CHECK-SAME: <td align="left">foo</td><td align="left">0</td> // CHECK-SAME: <td align="left">&Element\{"foo",0 S64b,char\}</td> // CHECK: <td align="left"><b>Environment: </b></td>
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits