jlebar marked an inline comment as done. ================ Comment at: test/Modules/ModuleDebugInfo.cpp:10 @@ -9,3 +9,3 @@ // RUN: cat %t-mod.ll | FileCheck %s // RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s ---------------- jlebar wrote: > jroelofs wrote: > > While you're here, may as well shorten these three lines to: > > > > > > ``` > > // RUN: %clang_cc1 -triple %itanium_abi_triple -x objective-c++ -std=c++11 > > -debug-info-kind=limited -fmodules -fmodule-format=obj > > -fimplicit-module-maps -DMODULES -fmodules-cache-path=%t %s -I %S/Inputs -I > > %t -emit-llvm -o %t.ll -mllvm -debug-only=pchcontainer | FileCheck %s > > --check-prefix=CHECK --check-prefix=CHECK-NEG > > ``` > > > > (as long as you also move the one CHECK-NEG-NOT line up before all of the > > other `CHECK` lines) > I don't think that means the same thing? CHECK-NOT: foo checks that "foo" > does not appear between the last match (or the beginning of the file, if > there was no last match) *and the next match*. Oh, I see, it's CHECK-NEG-NOT, so there are no other instances of CHECK-NEG, it's fine how you say. I'll change it, sure.
http://reviews.llvm.org/D17051 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
