harlanhaskins added inline comments.
================ Comment at: clang/include/clang/Basic/FileManager.h:217 /// - /// This returns NULL if the file doesn't exist. + /// This returns a \c std::error_code if there was an error loading the file. /// ---------------- JDevlieghere wrote: > harlanhaskins wrote: > > jkorous wrote: > > > Does that mean that it's now safe to assume the value is `!= NULL` in the > > > absence of errors? > > That's the intent of these changes, yes, but it should also be documented. 👍 > In line with the previous comment, should we just pass a reference then? I'm fine with doing that, but it would introduce a significant amount more churn into this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
