rogfer01 created this revision. rogfer01 added reviewers: eli.friedman, ddunbar. Herald added a project: clang. Herald added a subscriber: cfe-commits. rogfer01 edited reviewers, added: efriedma; removed: eli.friedman.
I have failures in this test because the `grep @b` gets confused by the `clang version` including a repository name like this !1 = !{!"clang version 10.0.0 (git@build-machine:llvm/llvm-monorepo.git fe958c0e8c89ec663c8e551936778e2cbb460154)"} I considered something like `grep -w` but my understanding of the manpages was that that isn't super portable. So I think it is easier to make clang not to output that metadata using `-fno-ident`. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65635 Files: clang/test/CodeGen/constant-comparison.c Index: clang/test/CodeGen/constant-comparison.c =================================================================== --- clang/test/CodeGen/constant-comparison.c +++ clang/test/CodeGen/constant-comparison.c @@ -1,5 +1,5 @@ // RUN: %clang_cc1 -emit-llvm %s -o - 2>&1 | not grep warning -// RUN: %clang_cc1 -emit-llvm %s -o - | grep @b | count 1 +// RUN: %clang_cc1 -fno-ident -emit-llvm %s -o - | grep @b | count 1 int a, b; int *c1 = 1 < 2 ? &a : &b;
Index: clang/test/CodeGen/constant-comparison.c =================================================================== --- clang/test/CodeGen/constant-comparison.c +++ clang/test/CodeGen/constant-comparison.c @@ -1,5 +1,5 @@ // RUN: %clang_cc1 -emit-llvm %s -o - 2>&1 | not grep warning -// RUN: %clang_cc1 -emit-llvm %s -o - | grep @b | count 1 +// RUN: %clang_cc1 -fno-ident -emit-llvm %s -o - | grep @b | count 1 int a, b; int *c1 = 1 < 2 ? &a : &b;
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits