ro marked 2 inline comments as done.
ro added inline comments.
================
Comment at: include/clang/Basic/LangStandard.h:19
+/// standard and possible actions.
+enum Language {
+ Unknown,
----------------
rnk wrote:
> Is it feasible to make this an `enum class`? I'm worried about namespace
> clashes on these otherwise very short names, like C, CXX, HIP, etc. It should
> be straightforward and mechanical to replace most existing instances of
> `InputKind::` with `Language::`. It would also remove the need to make an
> exception for `LF_OpenCL`.
That works perfectly indeed, and is way clearer than my hack
with LF_OpenCL.
There's only one downside: I had to change InputKind.Lang
from a 4-bit bitfield to Language, otherwise neither assignment
nor comparison would work. No idea if that's really a problem.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65562/new/
https://reviews.llvm.org/D65562
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
