hokein added a comment.

thanks for the detailed comments!



================
Comment at: clang-tools-extra/clangd/test/request-reply.test:22
+---
+{"jsonrpc":"2.0","id":0,"result":{"applied":false}}
+#      CHECK:  "code": -32001,
----------------
sammccall wrote:
> please use increasing IDs and don't reuse them. (In general, but particularly 
> in this test)
I believe `0` is right here, this is a client reply for the server request `0` 
(applyEdit).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65387/new/

https://reviews.llvm.org/D65387



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to