hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp:26 + VisitedImplicitInitializer = true; + Match("initializer", Init->getSourceLocation()); + return ExpectedLocationVisitor< ---------------- is it intentional to run for case `!Init->IsWritten()` where the source location is invalid? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65735/new/ https://reviews.llvm.org/D65735 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits