juliehockett accepted this revision. juliehockett added a comment. LGTM with a comment correction
================ Comment at: clang-tools-extra/clang-doc/Representation.h:117 Reference(llvm::StringRef Name) : Name(Name) {} - Reference(llvm::StringRef Name, StringRef Path) : Name(Name), Path(Path) {} + // An empty path means the info is in the globalnamespace because the path is + // a composite of the parent namespaces. ---------------- s/globalnamespace/global namespace ================ Comment at: clang-tools-extra/clang-doc/Representation.h:123 : USR(USR), Name(Name), RefType(IT) {} + // An empty path means the info is in the globalnamespace because the path is + // a composite of the parent namespaces. ---------------- s/globalnamespace/global namespace CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64958/new/ https://reviews.llvm.org/D64958 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits