jvikstrom added a comment. In D65738#1614897 <https://reviews.llvm.org/D65738#1614897>, @hokein wrote:
> Haven't looked at the patch in details. > > Looks like the patch is doing different things, and the test just covers a > small set of the code. > > 1. find and parse the theme definition files `json` ; > 2. define related data structures to save the TM scopes and do the > transformation; > 3. handle changes of the theme; > > could we narrow it further? I think we could just implement 1) for this > patch. Removed everything that wasn't loading a TM theme. Also added an interface for a TM scope that we parse into (which I also added a test for). The getFullNamedTheme function is not used (or exported) anywhere for now though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65738/new/ https://reviews.llvm.org/D65738 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
