tycho added a comment. Two things:
- I'm curious why we would want to force `-O2`/`-O3` instead of just allowing `-Os`/`-Oz` to be used with LTO. Is optimizing for size combined with LTO really that unusual? I've built several projects using GCC with `-Os -flto` and the size reduction over plain `-Os` or `-O2 -flto` has been substantial enough to warrant that combination on release builds as well. I assume I might be missing something here, though, since someone mentioned this above (I don't understand the response to it though). - This change is missing a fix for the option parsing in `tools/gold/gold-plugin.cpp` (`option::process_plugin_option`), which also complains about the `-Os`/`-Oz` arguments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63976/new/ https://reviews.llvm.org/D63976 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
