plotfi added a comment. In D65829#1617864 <https://reviews.llvm.org/D65829#1617864>, @compnerd wrote:
> @lhames - I like the `logAllUnhandledErrors`! @lhames @compnerd @jkorous Only downside to using logAllUnhandledErrors over just letting the llvm::Expected's destructor handle the error print out is that logAllUnhandledErrors only logs the errors. It doesn't crash the rest of the deadlocking DirectoryWatcher test. So I had to include logAllUnhandledErrors along with exit(EXIT_FAILURE). Anyhow, it seems we have consensus so I will land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65829/new/ https://reviews.llvm.org/D65829 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
