ABataev added a comment.
> I should have reported that the current implementation isn't complete for
> OpenMP 4.5. For example, on target teams, reduction(+:x) map(x) is an error
> but not map(x) reduction(+:x). So there are bugs to fix, and maybe this will
> evolve into multiple patches, but I want to be sure I'm on the right path
> first.
It is just a bug, not a missing feature. Just file a bug report for it.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:10895
+ // combined construct.
+ if (CurrDir == OMPD_target) {
OpenMPClauseKind ConflictKind;
----------------
jdenny wrote:
> ABataev wrote:
> > I would suggest to guard this change and limit this new functionality only
> > for OpenMP 5.0.
> Do you agree that this is strictly an extension to 4.5 that won't alter the
> behavior of 4.5-conforming applications?
>
> Do we generally want to complain about the use of extensions, or is there
> another reason for the guard you suggest?
No. It is incorrect according to OpenMP 4.5 and we shall emit diagnostics here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65835/new/
https://reviews.llvm.org/D65835
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
