thakis added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3559
// CollectArgsForIntegratedAssembler().
- if (TC.useIntegratedAs()) {
+ if (TC.useIntegratedAs() || isa<PreprocessJobAction>(JA)) {
Args.ClaimAllArgs(options::OPT_mrelax_all);
----------------
dyung wrote:
> thakis wrote:
> > We shouldn't claim the OPT_m flags if we don't use integrated-as. Claiming
> > Wa_COMMA and Xassembler makes sense to me.
> If we do not, then one of the tests you included in this change will fail if
> a platform defaults to not using the integrated assembler. Should I remove
> this change and just update the test to explicitly set
> -fintegrated-as/-fno-integrated-as and test for the expected result?
Yes, tests for the -m flags should pass `-fintegrated-as`. Sorry about missing
that. Out of curiosity, which platforms still use external assemblers by
default?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65974/new/
https://reviews.llvm.org/D65974
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
