DiegoAstiazaran marked 2 inline comments as done.
DiegoAstiazaran added inline comments.


================
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250
+  // The resulting path is "../../../A/B/D" instead of a "../D". It is correct
+  // but it would be better to have the shorter version.
   StringRef Dir = Directory;
----------------
juliehockett wrote:
> Would `llvm::sys::path::remove_dots()` do this? It might not, but is worth 
> investigating.
`llvm::sys::path::remove_dots()` removes all `../` (except for leading `../`) 
so the resulting path in the example would be `../A/B/D`, which is not correct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65987/new/

https://reviews.llvm.org/D65987



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to