compnerd added inline comments.
================ Comment at: clang/include/clang/Driver/Types.h:107 + llvm::opt::DerivedArgList &DAL, ID Id, + llvm::SmallVectorImpl<phases::ID> &Phases); ---------------- This really makes things confusing, perhaps renaming `getCompilationPhases` to `getCompletePhaseList` or something might make it less confusing? Although, I suppose that you do have follow up patches to improve this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65993/new/ https://reviews.llvm.org/D65993 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
