NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
Looks great, thanks! I'd appreciate direct CFG tests for the part that changes the CFG (cf. `test/Analysis/cfg.cpp`), but i don't insist. Let's make sure @jfb is happy and commit :) ================ Comment at: lib/Analysis/CFG.cpp:1104 bool AlwaysTrue = true, AlwaysFalse = true; + // Track value of both subexpression. If either side is always + // true/false, another warning should have already been emitted. ---------------- Typo: "subexpressions". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66044/new/ https://reviews.llvm.org/D66044 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits