jlebar added inline comments.

================
Comment at: lib/Driver/Tools.cpp:10707
@@ +10706,3 @@
+    // ptxas does not accept -g option if optimization is enabled, so we ignore
+    // compiler's -O* options if we want debug info.
+    CmdArgs.push_back("-g");
----------------
I think this is would be very surprising to users.  -g does not usually have a 
large performance impact, so -O2 -g does not generally mean "generate slow 
code," as far as I know.  I'm concerned that this will result in people 
accidentally compiling with ptxas -O0 (which is why I didn't do it like this to 
begin with).

Can we accomplish this in a more explicit way?


http://reviews.llvm.org/D17111



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to