Charusso added a comment. I realized that it is meaningless what separator we use to list the checkers, so I have picked `;`. The `,` is limited to the `analyzer-config` list.
================ Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:192-197 + /// Pair of checker name and enable/disable to do analysis. + std::vector<std::pair<std::string, bool>> CheckerAnalysisVector; + + /// Vector of checker names to do not emit warnings. + std::vector<std::string> CheckerSilenceVector; ---------------- Szelethus wrote: > Charusso wrote: > > NoQ wrote: > > > `CheckerAnalysisVector` sounds like a vector of checkers that will be > > > subject to analysis. But in reality they are the ones that are analyzing > > > and nobody is analyzing them. > > > > > > The old name isn't very expressive either, but at least it sounds cool >.< > > > > > > Maybe `EnabledCheckers`, `SilencedCheckers`? > > The problem with `EnabledCheckers` it is a lie. It would be just `Checkers` > > and then whether a given checker is enabled or disabled is determined > > later. `CheckerEnableVector` and `CheckerSilenceVector` may would be okay. > Aye, I've come across this field multiple times and there isn't really a good > name for it. However, is this correct? Are these *checkers*, or checkers > *and* packages? `SilencedCheckersAndPackagesAsCommaSeparatedListSplittedToStringRefVector` simplified to `SilencedCheckers` and `CheckersControlList` to `Checkers`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
