aaron.ballman added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:26
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
+ using readability::NamespaceCommentCheck;
+
----------------
dsanders wrote:
> aaron.ballman wrote:
> > I would rather use the fully-qualified names below -- the namespaces are
> > actually of interest when needing to see what checks rely on what other
> > modules quickly.
> In that case I think I need some more detail on the alphabetical order I need
> to preserve. Do the namespaces factor into the order? If so, then
> PreferIsaOrDynCastInConditionalsCheck was in the wrong place prior to this
> patch and add_new_check.py is behaving correctly. If not, then the existing
> order was correct but add_new_check.py is inserting new lines incorrectly
We usually alphabetize based on the string literal for the check being
registered. This usually results in the list also being sorted by the check
implementation class name, but not always.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65919/new/
https://reviews.llvm.org/D65919
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
