SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added a comment.

> Since this is user documentation, we should only add it here once it is true.

Yep, good point, I also wanted to capture our discussions on the list. But yes, 
let's hold this back until we're ready with the pragmas.



================
Comment at: docs/LanguageExtensions.rst:3068-3069
 
+There are loop hints that control transformations (e.g. vectorization, loop
+unrolling) and there loop hints that set transformation options (e.g.
+``vectorize_width``, ``unroll_count``).  Pragmas setting transformation options
----------------
Meinersbur wrote:
> `vectorize_width` also "controls" a transformation. Is it that in our 
> interpretation, `vectorize(enable)` overrides the profitability heuristic by 
> taking out the "do not apply at all" option without setting any other option?
I think I need to think a little bit more about this:

> Is it that in our interpretation, vectorize(enable) overrides the 
> profitability heuristic by taking out the "do not apply at all" option 
> without setting any other option?

but I would answer this with "yes". But just checking, what exactly do you mean 
with "do not apply at all option"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66199/new/

https://reviews.llvm.org/D66199



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to