sepavloff marked 2 inline comments as done. sepavloff added inline comments.
================ Comment at: clang/docs/LanguageExtensions.rst:3152 +rounding mode. This option is experimental; the compiler may ignore an explicit +rounding mode in some situations. + ---------------- andrew.w.kaylor wrote: > You should say something about whether the rounding mode is applied or > assumed. The rounding mode argument in the constrained FP intrinsics is > assumed. The compiler is not required to do anything to force the hardware > into that rounding mode. I think we want that behavior here as well. I > believe this follows the semantics of the STDC FENV_ROUND pragmas that were > introduced by ISO TS-18661. Hm. I understood the proposal as if pragma FENV_ROUND is applied. If I am wrong, and that pragma is only a hint to compiler, it is not suitable for our purposes. We need a mean to generate constrained intrinsics from C/C++ code. it would facilitate adaptation of LLVM passes for specific floating point options, including rounding, exception behavior, FENV_ACCESS an so on. It also would allow users to tune code generation. In this case `pragma FENV_ROUND` is a different functionality, which should be developed separately. ================ Comment at: clang/docs/LanguageExtensions.rst:3159 +This option is experimental; the compiler may ignore an explicit exception +behavior in some situations. + ---------------- andrew.w.kaylor wrote: > I'm not sure what this is supposed to mean. What are the circumstances under > which the compiler may ignore an explicit exception behavior? Do you mean > that it isn't supposed to happen but it might while the feature is under > development? The purpose is to have a tool that would allow developing support of constrained nodes in LLVM pipeline. So we discourage using this pragma by end users. Yes, you are right, it means a feature under development. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65997/new/ https://reviews.llvm.org/D65997 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
