Anastasia added inline comments.
================ Comment at: docs/ReleaseNotes.rst:173 + +- Added initial support for implicitly including OpenCL BIFs using + efficient trie lookup generated by TableGen. A corresponding ---------------- svenvh wrote: > mantognini wrote: > > If the BIF acronym wasn't introduced before, it should be replaced with > > "builtin functions". It seems we don't have more file context in this > > review so I cannot tell. > BIFs -> built-in functions builtin is a more common spelling in Clang docs. ================ Comment at: docs/ReleaseNotes.rst:176 + frontend only flag ``-fadd-opencl-builtins`` has been added to + enable trie during parsing. + ---------------- svenvh wrote: > The option does not only "enable a trie" during parsing. I'd suggest to just > drop "to enable trie during parsing". We don't have to describe all details here btw, but just the main ones. I would like to say what the flag is used for explicitly rather than leaving the room for interpretations. Btw, would it make sense to document this flag in UserManual? https://clang.llvm.org/docs/UsersManual.html#opencl-specific-options ================ Comment at: docs/ReleaseNotes.rst:220 + + - Method qualifiers are allowed with address spaces; + ---------------- mantognini wrote: > Maybe something along these line would be better? > > Methods can be overloaded for different address spaces. > > Or, if you want to emphasis the qualifiers, > > Method qualifiers now include address space. I prefer the second one, as the first one can be read as parameter address space. ================ Comment at: docs/ReleaseNotes.rst:222 + + - Address space deduction has been extended for C++ use cases; + ---------------- mantognini wrote: > This seems to be already included in previous point. Do you mean method qualifiers? I don't see the connection? ================ Comment at: docs/ReleaseNotes.rst:232-233 + +- OpenCL specific type: images, samplers, events, pipes, except + for blocks. + ---------------- mantognini wrote: > I would suggest this: > > OpenCL-specific types, except within blocks: [...] I mean with the exception of blocks here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66294/new/ https://reviews.llvm.org/D66294 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
