Author: dergachev Date: Mon Aug 19 19:15:47 2019 New Revision: 369319 URL: http://llvm.org/viewvc/llvm-project?rev=369319&view=rev Log: [analyzer] NFC: Drop support for extra text attached to bug reports.
It was introduced in 2011 but never used since then. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h?rev=369319&r1=369318&r2=369319&view=diff ============================================================================== --- cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h (original) +++ cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h Mon Aug 19 19:15:47 2019 @@ -88,7 +88,6 @@ public: using VisitorList = SmallVector<std::unique_ptr<BugReporterVisitor>, 8>; using visitor_iterator = VisitorList::iterator; using visitor_range = llvm::iterator_range<visitor_iterator>; - using ExtraTextList = SmallVector<StringRef, 2>; using NoteList = SmallVector<std::shared_ptr<PathDiagnosticNotePiece>, 4>; protected: @@ -106,7 +105,6 @@ protected: const ExplodedNode *ErrorNode = nullptr; SmallVector<SourceRange, 4> Ranges; const SourceRange ErrorNodeRange; - ExtraTextList ExtraText; NoteList Notes; /// A (stack of) a set of symbols that are registered with this @@ -288,17 +286,6 @@ public: return Notes; } - /// This allows for addition of meta data to the diagnostic. - /// - /// Currently, only the HTMLDiagnosticClient knows how to display it. - void addExtraText(StringRef S) { - ExtraText.push_back(S); - } - - virtual const ExtraTextList &getExtraText() { - return ExtraText; - } - /// Return the "definitive" location of the reported bug. /// /// While a bug can span an entire path, usually there is a specific Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp?rev=369319&r1=369318&r2=369319&view=diff ============================================================================== --- cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp (original) +++ cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp Mon Aug 19 19:15:47 2019 @@ -2878,11 +2878,6 @@ void BugReporter::FlushReport(BugReportE Pieces.push_front(*I); } - // Get the meta data. - const BugReport::ExtraTextList &Meta = report->getExtraText(); - for (const auto &i : Meta) - PD->addMeta(i); - updateExecutedLinesWithDiagnosticPieces(*PD); Consumer->HandlePathDiagnostic(std::move(PD)); } _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits