NoQ added a comment. In D62899#1634657 <https://reviews.llvm.org/D62899#1634657>, @Szelethus wrote:
> In D62899#1551312 <https://reviews.llvm.org/D62899#1551312>, @NoQ wrote: > > > In D62899#1549715 <https://reviews.llvm.org/D62899#1549715>, @Szelethus > > wrote: > > > > > Added a proper testfile. The only downside of it is that it doesn't test > > > anything. > > > > > > Use creduce! > > > I would, but I'm not even sure what to look for, really. When you already have code and have a real-world example that it works but you don't have a reduced test case, just use "anything changes" as the reduce condition, because you're basically interested in the answer to "why does this patch change anything at all?". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62899/new/ https://reviews.llvm.org/D62899 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
