sdmitriev added a comment. In D64943#1633164 <https://reviews.llvm.org/D64943#1633164>, @ABataev wrote:
> In D64943#1619958 <https://reviews.llvm.org/D64943#1619958>, @sdmitriev wrote: > > > As I understand ‘atexit’ solution would be target dependent (‘__cxa_atexit’ > > on Linux and ‘atexit’ on Windows) whereas @llvm.global_ctors/dtors > > variables offer similar and platform neutral functionality > > (http://llvm.org/docs/LangRef.html#the-llvm-global-ctors-global-variable). > > Why do you think that ‘atexit’ is a better choice? > > > Because it does not work on Windows, better to have portable solution, if > possible. @vzakhari has already committed his fix for llvm.global_dtors (https://reviews.llvm.org/D66373), so I assume use of llvm.global_dtors in this patch would no longer cause problems on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
