gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land.
LGTM, although I'd be more comfortable with a whitelist of macros. ================ Comment at: clang-tools-extra/test/clang-tidy/google-runtime-references.cpp:156 +DEFINE_F(func) {} \ No newline at end of file ---------------- Please add back the newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66631/new/ https://reviews.llvm.org/D66631 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits