gribozavr accepted this revision.
gribozavr added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clang-tidy/utils/TypeTraits.cpp:57
return true;
+ // Don't perform the check on an ill-formed Decl. As we will visit every
class
+ // member recursively, an ill-formed Decl may cause an infinite loop during
----------------
I'd suggest to not mention the infinite loop. Just say that it is impossible to
determine whether the decl is trivially constructible if there was an error.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66874/new/
https://reviews.llvm.org/D66874
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
