hokein added a comment.

In D66881#1649044 <https://reviews.llvm.org/D66881#1649044>, @jvikstrom wrote:

> Oh, was not aware we needed to dispose the extension as well.
>
> I think you should probably add the SemanticHighlightingFeature to the 
> context.subscriptions as well, right? (because I didn't when I did the 
> cleanup patch for it, sorry)


good catch, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66881/new/

https://reviews.llvm.org/D66881



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to