jkorous added inline comments.
================ Comment at: clang/include/clang/Index/IndexingAction.h:60 + +inline std::unique_ptr<ASTConsumer> createIndexingASTConsumer( + std::shared_ptr<IndexDataConsumer> DataConsumer, ---------------- gribozavr wrote: > jkorous wrote: > > Why not use default argument instead of overloading? > Writing a whole lambda in a default argument seemed to be a bit too much. I > can change to a default argument if you think it is better. WDYT? Seems like we do that in couple places (`VisibleModuleSet::setVisible` or `FinishTemplateArgumentDeduction`). Anyway, it's no big deal, I'm fine with either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66879/new/ https://reviews.llvm.org/D66879 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
