alexfh added a comment.
Mostly LG, if you've verified that this works. A couple of comments below.
================
Comment at: clang-tools-extra/clang-tidy/add_new_check.py:192
+ else:
+ match = re.search('registerCheck<(.*)> *\( *(?:"([^"]*)")?', line)
+ last_line = None
----------------
Are there actually any registerCheck calls with spaces between the `>` and the
`(`? Should we clang-format these instead of supporting them in the script?
================
Comment at: clang-tools-extra/clang-tidy/add_new_check.py:193
+ match = re.search('registerCheck<(.*)> *\( *(?:"([^"]*)")?', line)
+ last_line = None
+ if match:
----------------
I'd call this previous_line or prev_line. "Last" is a bit misleading here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66505/new/
https://reviews.llvm.org/D66505
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
