aaron.ballman marked an inline comment as done.
aaron.ballman added inline comments.


================
Comment at: lib/Lex/PPMacroExpansion.cpp:523
+      llvm::sys::path::filename(getSourceManager().getFilename(
+          M.getLocalDirective()->getLocation())) == "stdatomic.h") {
+    Diag(Identifier, diag::warn_pp_macro_deprecated)
----------------
rsmith wrote:
> This assumes there is a local directive for the macro. There need not be (it 
> could be imported from a module). We should presumably check to see if all 
> active macro directives are from that header instead.
I'm not familiar with how that's done -- is there some existing code doing 
something similar I should model off of? Also, what would the test case look 
like for that scenario?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67023/new/

https://reviews.llvm.org/D67023



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to