Mordante added inline comments.

================
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1095
+  default:
+    assert(false && "Not a reference type specifier");
+  }
----------------
Wouldn't it be better to use `llvm_unreachable("Not a reference type 
specifier");`
Maybe also move this line out of the switch, allowing the compiler to warn 
about not handled enumeration values.


================
Comment at: clang/lib/Sema/SemaType.cpp:1266
+  default:
+    assert(false && "Cannot map TST to unary transform type");
+  }
----------------
Same here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67052/new/

https://reviews.llvm.org/D67052



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to