kousikk added a comment. Sure I'll add a test case!
================ Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:196 + return llvm::ErrorOr<std::unique_ptr<llvm::vfs::File>>(std::make_error_code(std::errc::is_a_directory)); + } + } ---------------- arphaman wrote: > This change dropped the createFile call, and didn't fix the issue where the > same could happen at the end of the function. Could you please perform this > check and return inside of `createFile` instead? This would ensure that both > uses are fixed. Ah sorry, I didn't mean to drop the `createFile()` call. Sure will fix inside createFile() instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
