rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
lgtm with the GlobalArrayDestructor name. ================ Comment at: include/clang/AST/GlobalDecl.h:34 AtExit, + GlobalDestructor }; ---------------- Maybe we should rename this GlobalArrayDestructor, since it's only used for arrays. Later, we can come back and avoid emitting these when using the MS ABI, since we already have the `?__F` finalizer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
