Szelethus accepted this revision. Szelethus added a reviewer: steakhal. Szelethus added a comment. This revision is now accepted and ready to land.
Some nits inline, otherwise LGTM. @steakhal, do you have anything to add to this? ================ Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:191 static TaintPropagationRule - getTaintPropagationRule(const FunctionDecl *FDecl, StringRef Name, + getTaintPropagationRule(const GenericTaintChecker *Checker, + const FunctionDecl *FDecl, StringRef Name, ---------------- How about only passing `CustomPropagations`? ================ Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:605 // Mark the given argument. - assert(ArgNum < CE->getNumArgs()); State = State->add<TaintArgsOnPostVisit>(ArgNum); ---------------- I get that there isn't much substance to this assert, but why remove it? We might as well populate the lines in between that and the branch. ================ Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:844 if (Config) - Checker->parseConfiguration(Mgr, Option, std::move(Config).getValue()); + Checker->parseConfiguration(Mgr, Option, std::move(Config.getValue())); } ---------------- Wasn't this commited before? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits