gribozavr accepted this revision.
gribozavr added a comment.
Still LGTM, just some nitpicks to replace iterator usage with index-based
accesses (which I believe is simpler).
================
Comment at:
clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:569
SmallVectorImpl<BugReport *> &bugReports) {
- return &*eqClass.begin();
+ return eqClass.getReports().begin()->get();
}
----------------
`getReports()[0]` ?
================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2803
assert(I != E);
- const BugType& BT = I->getBugType();
+ const BugType& BT = (*I)->getBugType();
----------------
```
assert(!EQ.getReports().empty());
const BugType& BT = EQ.getReports()[0]->getBugType();
```
?
================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:3139
+ const auto *R =
+ dyn_cast<PathSensitiveBugReport>(EI->getReports().begin()->get());
if (!R)
----------------
`getReports()[0]` ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67024/new/
https://reviews.llvm.org/D67024
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
