aaron.ballman added a comment.

In D67140#1659978 <https://reviews.llvm.org/D67140#1659978>, @Szelethus wrote:

> In D67140#1659907 <https://reviews.llvm.org/D67140#1659907>, @NoQ wrote:
>
> > In D67140#1659872 <https://reviews.llvm.org/D67140#1659872>, @aaron.ballman 
> > wrote:
> >
> > > If we're okay with the inconsistency but still feel like giving ourselves 
> > > more work, adding proper punctuation to Static Analyzer diagnostics would 
> > > at least make them grammatically correct. :-D
> >
> >
> > I'd love us some punctuation! Unfortunately the last time a person who 
> > actually speaks English committed actively to the Static Analyzer was, 
> > like, a couple of years ago at least (:
>
>
> I guess there's a joke waiting to be made about a couple Hungarians and 
> Russians discussing how to write proper English :^)


LOL!

> With that said, we could ask @whisperity to chip in more, he has an 
> ever-growing academic background, and a keen eye for grammatical errors.

I am also happy to help out with this task, though it would have to be on my 
own time as a best-faith effort.

In D67140#1659982 <https://reviews.llvm.org/D67140#1659982>, @gribozavr wrote:

> We should take a page from desktop software here. If the messages were in a 
> separate file, there would be a lot of people capable of mass-editing them. 
> When messages are hardcoded in the tool code, navigating and editing them 
> requires more skill, and definitely a lot more jumping around.


Agreed -- this is why Clang puts its diagnostics into .td files (it's not 
perfect because people still sometimes use positional args when %select{} would 
be easier to localize, but it's a great start). I think the difficulty the 
static analyzer and clang-tidy would have doing this is in figuring out how to 
organize the diagnostics without breaking checker layering.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67140/new/

https://reviews.llvm.org/D67140



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to