hans accepted this revision. hans added a comment. This revision is now accepted and ready to land.
lgtm with comment > The main functional change is that -fno-ms-compatibility now no longer > sends us down the hard error diagnostic code path for ObjC fixed enums. > Instead, complete-but-not-fixed MS enums go down the C99 codepath which > issues a -Wmicrosoft-enum-value warning about the enum value not being > representable as an 'int'. This was highlighted as the single largest > blocker to compiling windows.h with -fno-ms-compatibility, so this > should make that feasible. Should there be a test exercising this part? The updated tests both have -fms-compatibility, so were already just warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67304/new/ https://reviews.llvm.org/D67304 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
