thakis marked 3 inline comments as done. thakis added a comment. Thanks for the thorough review! Indeed, this still gets `[]<bool b = true && false>(A &&a){}();` wrong, for the reason you mention.
================ Comment at: clang/lib/Format/TokenAnnotator.cpp:50 + // Skip <...> if present. + if (Left->Previous && Left->Previous->is(tok::greater) && + Left->Previous->MatchingParen && ---------------- krasimir wrote: > The first `Left->Previous` check is unnecessary here, following the previous > `if`. I removed the previous `if`, it makes the function more symmetric. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67246/new/ https://reviews.llvm.org/D67246 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits