Szelethus added a comment. Looks great! Are we sure that `PathDiagnostic.h` is a good header name?
================ Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:26 #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Config/config.h" #include "clang/Format/Format.h" ---------------- NoQ wrote: > This needed to go up because that's where `CLANG_ENABLE_STATIC_ANALYZER` is > defined. Let's add some scary comments then, to warn everyone trying to blindly clang-format this file. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67419/new/ https://reviews.llvm.org/D67419 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
