gribozavr added a comment. Are you planning to move users of these options -- like `PlistDiagnostics` -- to libAnalysis?
================ Comment at: clang/include/clang/Analysis/PathDiagnostic.h:81 + /// because deterministic mode is always superior when done right, but + /// for some consumers is experimental and needs to be off by default. + bool ShouldWriteStableReportFilename; ---------------- "but for some consumers is experimental" -- parse error. What is experimental? ================ Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:534 + C.push_back(new PlistDiagnostics(std::move(DiagOpts), s, PP, CTU, + /*supportsMultipleFiles*/ false)); +} ---------------- I think we need an equal sign for ClangTidy to pick it up: `/*foo=*/` Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67420/new/ https://reviews.llvm.org/D67420 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
