tlively added a comment. In D67425#1668831 <https://reviews.llvm.org/D67425#1668831>, @aheejin wrote:
> LGTM. > > - Maybe we can lower these > <https://github.com/llvm/llvm-project/blob/87baae85cdee84b43986f1d8d0fac469c7e9521b/llvm/include/llvm/CodeGen/ISDOpcodes.h#L494-L550> > to these new instructions later? (I'm not very sure what the difference > between versions with and without `VECTOR`, because the versions without > `VECTOR` seem to be able to take vector arguments as well.) > - Will this simplify the complicated lowering of `SIGN_EXTEND_INREG` > <https://github.com/llvm/llvm-project/blob/87baae85cdee84b43986f1d8d0fac469c7e9521b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp#L1241-L1279>? Yes, good points. I will make a note to go back and clean these up once we are able to emit these instructions without explicit user opt-in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67425/new/ https://reviews.llvm.org/D67425 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits