Szelethus added a comment. Aha, so every user gets to create their own `PathDiagnosticConsumerOptions` object, makes sense! There is no interface misconception, because `-analyzer-config` will only configure what the analyzer would tinket with. I like this patch! If you dont mind, I'd prefer to have one last round with this, but otherwise LGTM.
================ Comment at: clang/include/clang/Analysis/PathDiagnostic.h:63 +/// Most of these options are currently supported by very few consumers. +struct PathDiagnosticConsumerOptions { + /// Whether to include additional information about macro expansions ---------------- Lets delete the default constructor. It would be an option to generate this with the analyzer secific `.def` file, but since we have so few users, lets force them to create this object manually :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67420/new/ https://reviews.llvm.org/D67420 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits