khchen marked 3 inline comments as done.
khchen added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1548
+ {M.gccSuffix(),
+ "/../../../../riscv64-unknown-elf/lib" + M.gccSuffix()});
+ });
----------------
kito-cheng wrote:
> It could be "riscv32-unknown-elf" other than "riscv64-unknown-elf".
fixed
================
Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:129
+ }
+
std::string Linker = getToolChain().GetProgramPath(getShortName());
----------------
kito-cheng wrote:
> This change seems like unrelated to multi-lib, could you split this change
> into new patch and add a test for that?
Enabling multi-lib uses
/Inputs/multilib_riscv_elf_sdk/riscv64-unknown-elf/bin/ld so we need to specify
the emulation format.
================
Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:132
if (D.isUsingLTO()) {
assert(!Inputs.empty() && "Must have at least one input.");
----------------
kito-cheng wrote:
> This part will conflict when apply patch, you might generate patch with
> https://reviews.llvm.org/D67409, could you rebase the patch with current
> trunk?
fixed
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67508/new/
https://reviews.llvm.org/D67508
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
