Szelethus added a comment.

We have no solid evidence to conclude that such an event should not occur at a 
`BlockEntrance`, so fixing this error mustn't be that bad. I certainly 
should've used `llvm::isa_or_nonnull`, so the patch overall makes sense, so I'm 
commiting it as is. With that said, this test case highlights a fundamental 
flaw in how loop wideining is implemented (hence it being off-by-default), and 
it should be addressed later separately.

I have talked to @NoQ about this behind the scenes, which is why I'm not 
concerned with the green check mark :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66716/new/

https://reviews.llvm.org/D66716



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to