lenary added inline comments.
================ Comment at: llvm/lib/Target/RISCV/RISCV.td:72 +def FeatureSaveRestore : SubtargetFeature<"save-restore", "EnableSaveRestore", + "true", "Enable save/restore.">; ---------------- lewis-revill wrote: > lenary wrote: > > Given the clang option defaults to false, I think it should here too, to > > avoid confusion in other frontends. > This is simply a case of a confusing parameter of the SubtargetFeature class. > > SubtargetFeature interprets this "true" string as 'Value the attribute to be > set to by feature'. IE: when the feature is enabled, what value should the > corresponding RISCVSubtarget variable be set to? Rather than a default value > for that variable. Ah, apologies for the confusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
